On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
<thomas.braun@xxxxxxxxxxxxxxxxxxx> wrote:
> completion: Add forgotten describe options
When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
(builtin/describe: introduce --broken flag, 2017-03-21)
Which do you add? (dirty and broken)
I had these questions when reading the subject (which is the
equivalent of reading the output of `git log --oneline` in the future)
I think a better wording might be
completion: add --broken and --dirty to describe
When the flags for broken and dirty were implemented in
b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
the completion was not updated, although these flags are useful
completions. Add them.
> Signed-off-by: Thomas Braun <thomas.braun@xxxxxxxxxxxxxxxxxxx>
> ---
The patch looks correct.
Thanks,
Stefan
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d934417475..0e16f017a4 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1385,7 +1385,7 @@ _git_describe ()
> __gitcomp "
> --all --tags --contains --abbrev= --candidates=
> --exact-match --debug --long --match --always --first-parent
> - --exclude
> + --exclude --dirty --broken
> "
> return
> esac
> --
> 2.14.2.746.g8fb8a945bc.dirty
>
