Re: [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 24.09.2017 um 03:26 schrieb Junio C Hamano:
> I wonder if we want a dedicated helper for them (perhaps about a
> dozen callers we have that fall into this pattern?) to call for the
> exact purpose, implemented as a thin-wrapper around the
> resolve_ref_unsafe() function, though.

refs_resolve_ref_unsafe() effectively has seven wrappers already:

	resolve_ref_unsafe()
	refs_resolve_refdup()
	resolve_refdup()
	refs_read_ref_full()
	read_ref_full()
	read_ref()

	ref_exists()

The last one already supplies a dummy SHA1 buffer; for a handful of
the others we could add and use variants that do the same.  I feel
that this API would become a bit crowded, though.

René



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux