Re: [QGit PATCH] Remove most ASSERT warnings in Git::setStatus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Marco Costalba" <mcostalba@xxxxxxxxx>:
> So I rather would prefer something like
> 
>   line.section('\t', 0, 0).section(' ', -1, -1).left(1)
> 
> because we could have more then one file separated by a tab, so
> 
>  line.section('\t', -2, -2).right(1)
> 
> it seems to me a little bit fragile. What do you think?

You're right.

> Also I don't understand why you consider the right most (right(1)),
> instead of the left most character as the status.

Only because it was simpler AND because I didn't know it was wrong.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux