Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Stefan Beller wrote: > >> Reported-by: Lars Schneider <larsxschneider@xxxxxxxxx> >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> >> --- >> Documentation/config.txt | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> Jonathan writes: > >>> You'll want to update Documentation/gitmodules.txt, too. >> >> No. /grumpycat >> >> It should already be fine, as I read it as if it is only relevant to >> "git submodule update" there, already: >> >> submodule.<name>.update:: >> Defines the default update procedure for the named submodule, >> i.e. how the submodule is updated by "git submodule update" >> command in the superproject. This is only used by `git >> submodule init` to initialize the configuration variable of >> the same name. Allowed values here are 'checkout', 'rebase', >> 'merge' or 'none'. See description of 'update' command in >> linkgit:git-submodule[1] for their meaning. Note that the >> '!command' form is intentionally ignored here for security >> reasons. > > I disagree. Actually, I think the git-config(1) blurb could just > point here, and that the text here ought to be clear about what > commands it affects and how an end user would use it. I tend to agree with the consolidation. It's not like this patch makes things worse, but as we've already diverted our attention to this area and took time to review, if it is a simple update we can make before we apply, that is better than having to remember and come back to patch the result of this step further. In any case, thanks for reporting, attempting to improve and reviewing, all.
