> -----Original Message----- > From: Martin Ågren [mailto:martin.agren@xxxxxxxxx] > Sent: Friday, September 22, 2017 7:37 PM > To: Ben Peart <Ben.Peart@xxxxxxxxxxxxx> > Cc: David Turner <David.Turner@xxxxxxxxxxxx>; Ævar Arnfjörð Bjarmason > <avarab@xxxxxxxxx>; Christian Couder <christian.couder@xxxxxxxxx>; > git@xxxxxxxxxxxxxxx; Junio C Hamano <gitster@xxxxxxxxx>; Johannes > Schindelin <johannes.schindelin@xxxxxx>; Nguyễn Thái Ngọc Duy > <pclouds@xxxxxxxxx>; Jeff King <peff@xxxxxxxx> > Subject: Re: [PATCH v8 08/12] fsmonitor: add a test tool to dump the index > extension > > On 22 September 2017 at 18:35, Ben Peart <benpeart@xxxxxxxxxxxxx> > wrote: > > Add a test utility (test-dump-fsmonitor) that will dump the fsmonitor > > index extension. > > > > Signed-off-by: Ben Peart <benpeart@xxxxxxxxxxxxx> > > --- > > Makefile | 1 + > > t/helper/test-dump-fsmonitor.c | 21 +++++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > create mode 100644 t/helper/test-dump-fsmonitor.c > > You forget to add the new binary to .gitignore. (In patch 12/12, you introduce > test-drop-caches, which you _do_ add to .gitignore.) > Oops. Thanks! Hopefully Junio can squash this in... > Martin > > diff --git a/t/helper/.gitignore b/t/helper/.gitignore index > 6f07de62d..0fe2e0440 100644 > --- a/t/helper/.gitignore > +++ b/t/helper/.gitignore > @@ -6,6 +6,7 @@ > /test-delta > /test-drop-caches > /test-dump-cache-tree > +/test-dump-fsmonitor > /test-dump-split-index > /test-dump-untracked-cache > /test-fake-ssh > -- > 2.14.1.727.g9ddaf86
