On 23 September 2017 at 06:04, Jeff King <peff@xxxxxxxx> wrote: > On Sat, Sep 23, 2017 at 01:34:52AM +0200, Martin Ågren wrote: > >> The way we handle `study` in builting/reflog.c still looks like it might >> leak. That will be addressed in the next commit. > > This confused me for a minute, since the leak is not visible in the > context. ;) But reading the next commit, it makes sense. Hmm, I added this so that a careful reader would /not/ get confused and go "wait, doesn't this look a bit fishy?". But I also didn't want to get into too many details, so of course it ended up confusing anyway. :-)