On Wed, Sep 20, 2017 at 09:41:12PM -0700, Jonathan Nieder wrote: > > Well, no...the idea is that this is a function which leaks a bunch of > > memory, and we shouldn't have to think hard about how often its leak can > > be triggered or how severe it is. We should just fix it. > > I forgot to say: thanks for writing such a pleasant patch. > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> You're welcome. :) > Here's such a patch. > > -- 8< -- > Subject: pathspec doc: parse_pathspec does not maintain references to args > [...] Yay! This looks great to me. I think the whole pathspec API could use better documentation, but this is certainly a good start. -Peff
