Johannes Schindelin wrote: > On Tue, 19 Sep 2017, Jonathan Nieder wrote: >> Could this example go near the top of the header instead? That way, >> it's easier for people reading the header to see how to use it. > > Funny, I am *so* used to examples being at the very end, from tutorials to > man pages. > > If my experience is any indication, I would rather keep this order. Sorry for the lack of clarity. I meant "near the top of the header *file*". [...] >> Are any of the Git for Windows users something that could go upstream >> along with this patch? That would help illustrate what a good caller >> looks like, which should help with reviewing future patches that use >> this code. > > I do not currently have the time to do that, that's why I did not > accompany the patch by any user. > > However, having said that, Ben's patch series will make for an *excellent* > user, fulfilling your wish. Ok. I think what you are saying is "go ahead --- anyone is welcome to grab some patches from git for windows and upstream them", which is a perfectly reasonable answer. [...] >> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > > Okay, I'll add that for v2. Will wait a couple of days in case more stuff > crops up. FWIW nothing I noticed came to the level of requiring a v2 imho. If any of the ideas I mentioned seems good, they can go in patches on top. The patch is in Junio's jch branch and I wouldn't be surprised if it hits "next" soon. Thanks again, Jonathan
