Re: [PATCH] commit: fix memory leak in `reduce_heads()`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] commit: fix memory leak in `reduce_heads()`
From: Jeff King <peff@xxxxxxxx>
Date: Wed, 20 Sep 2017 16:15:32 -0400
Cc: git@xxxxxxxxxxxxxxx, Junio C Hamano <gitster@xxxxxxxxx>
In-reply-to: <1505936846-2195-3-git-send-email-martin.agren@gmail.com>
References: <1505936846-2195-3-git-send-email-martin.agren@gmail.com>

On Wed, Sep 20, 2017 at 09:47:25PM +0200, Martin Ågren wrote:

> We don't free the temporary scratch space we use with
> `remove_redundant()`. Free it similar to how we do it in
> `get_merge_bases_many_0()`.

Yep, seems very straightforward, and there are no code paths where we
wouldn't want this.

-Peff

References:
- [PATCH] commit: fix memory leak in `reduce_heads()`
  - From: Martin Ågren

Prev by Date: Re: commit-msg hook does not run on merge with --no-ff option
Next by Date: Re: [PATCH v2 02/21] prefix_ref_iterator: break when we leave the prefix
Previous by thread: [PATCH] commit: fix memory leak in `reduce_heads()`
Next by thread: Re: [PATCH] commit: fix memory leak in `reduce_heads()`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux