Re: Behaviour of 'git stash show' when a stash has untracked files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 20, 2017 at 02:33:04PM +0900, Junio C Hamano wrote:

> Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx> writes:
> 
> > Some time ago, I stashed a few changes along with untracked files. I
> > almost forgot it until recently. Then I wanted to see what I change I
> > had in the stash. So I did a 'git stash show <num>'. It worked fine but
> > didn't say anything about the untracked files in that stash. That made
> > me wonder where the untracked files I added went. I then applied the
> > stash to see that they were still there but weren't listed in show.
> >
> > I understand that they aren't listed because 'git stash show' is
> > typically a "diff between the stashed state and its original parent" as
> > the documentation says but shouldn't there be at least a message that
> > the stash contains untracked files? Those untracked files are "part of
> > the stash" and I see no way to get information about their presence
> > currently.
> >
> > So, should this behaviour be changed?
> 
> Hmm, crickets tell us that nobody is all that interested in this, it
> seems.

Or sometimes people are just really behind in reading the mailing list. ;)

This seemed familiar, and indeed there was some discussion a few months
ago:

  https://public-inbox.org/git/CAOtcWM3mrQEqDnjMipzea7Kp+VueBFsZDL2zcJ=y0wgj9N4Vjw@xxxxxxxxxxxxxx/

I sketched out a possible solution in:

  https://public-inbox.org/git/20170317141417.g2oenl67k74nlqrq@xxxxxxxxxxxxxxxxxxxxx/

though I share your concerns over whether people would be annoyed to see
the existing "stash show" output changed.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux