Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list
From: Andreas Schwab <schwab@xxxxxxxxxxxxxx>
Date: Wed, 20 Sep 2017 18:28:53 +0200
Cc: Junio C Hamano <gitster@xxxxxxxxx>, Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx>, Michael Haggerty <mhagger@xxxxxxxxxxxx>, Alex Riesen <raa.lkml@xxxxxxxxx>, git@xxxxxxxxxxxxxxx
In-reply-to: <20170920052705.GC126984@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Tue, 19 Sep 2017 22:27:05 -0700")
References: <cb2d4d71c7c1db452b86c8076c153cabe7384e28.1505490776.git.mhagger@alum.mit.edu> <20170915184323.GU27425@aiede.mtv.corp.google.com> <b8951886-feab-a87a-9683-3c155cfa98a8@alum.mit.edu> <b03c7b09-853f-a2ed-f73e-7d946c90cedb@gmail.com> <20170920023008.GB126984@aiede.mtv.corp.google.com> <xmqqd16mowig.fsf@gitster.mtv.corp.google.com> <20170920052705.GC126984@aiede.mtv.corp.google.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

On Sep 19 2017, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:

> B. #define for_each_string_list_item(item, list) \
> 	if (list->items) \
> 		for (item = ...; ...; ... )
>
>    This breaks a caller like
> 	if (foo)
> 		for_each_string_list_item(item, list)
> 			...
> 	else
> 		...
>
>    making it a non-starter.

That can be fixed with a dangling else.

Andreas.

-- 
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list
  - From: Jonathan Nieder

References:
- [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Michael Haggerty
- Re: [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Jonathan Nieder
- Re: [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Michael Haggerty
- Re: [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Kaartic Sivaraam
- Re: [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Jonathan Nieder
- Re: [PATCH] for_each_string_list_item(): behave correctly for empty list
  - From: Junio C Hamano
- [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list
  - From: Jonathan Nieder

Prev by Date: Re: [PATCH v7 04/12] fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Next by Date: Re: [PATCH v7 04/12] fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Previous by thread: [PATCH v2] doc: camelCase the config variables to improve readability
Next by thread: Re: [PATCH v2] for_each_string_list_item: avoid undefined behavior for empty list
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]