On Tue, Sep 19, 2017 at 01:37:14PM -0700, Jonathan Nieder wrote:
> Torsten Bögershausen <tboegi@xxxxxx> wrote:
>
> > Some implementations of `echo` support the '-e' option to enable
> > backslash interpretation of the following string.
> > As an addition, they support '-E' to turn it off.
>
> nit: please wrap the commit message to a consistent line width.
>
> > However, none of these are portable, POSIX doesn't even mention them,
> > and many implementations don't support them.
> >
> > A check for '-n' is already done in check-non-portable-shell.pl,
> > extend it to cover '-n', '-e' or '-E-'
> >
> > Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
> > ---
> > t/check-non-portable-shell.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> An excellent change. Thanks for noticing and fixing this.
>
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Thanks for the review.
Junio, if you wouldn't mind to squash that in,
another fix is needed as well(trailing '-' after '-E') :
s/'-n', '-e' or '-E-'/'-n', '-e' or '-E'
^
