Ben Peart wrote: > Some stats on these same coding style errors in the current bash scripts: > > 298 instances of "[a-z]\(\).*\{" ie "function_name() {" (no space) > 140 instances of "if \[ .* \]" (not using the preferred "test") > 293 instances of "if .*; then" > > Wouldn't it be great not to have to write up style feedback for when > these all get copy/pasted into new scripts? Agreed. Care to write patches for these? :) (I think three patches, one for each issue, would do the trick.) Thanks, Jonathan