Re: [PATCH] pack: make packed_git_mru global a value instead of a pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 17, 2017 at 10:42 PM, Christian Couder
<christian.couder@xxxxxxxxx> wrote:
> On Sun, Sep 17, 2017 at 10:17 PM, phionah bugosi <bugosip@xxxxxxxxx> wrote:
>> Signed-off-by: phionah bugosi <bugosip@xxxxxxxxx>
>> ---
>>  builtin/pack-objects.c |  5 +++--
>>  cache.h                |  7 -------
>>  list.h                 |  6 ++++++
>>  packfile.c             | 12 ++++++------
>>  4 files changed, 15 insertions(+), 15 deletions(-)
>>
>> This patch makes packed_git_mru global a value instead of a pointer and
>> makes use of list.h
>
> Please explain _why_ you are doing that (why is the resulting code better).

Also the explanations should be in the commit message, that is above
your "Signed-off-by: ..." line.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux