On 17/09/17 14:42, Kaartic Sivaraam wrote:
On Sun, 2017-09-17 at 14:24 +0100, Phillip Wood wrote:
From that commit:
diff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh
new file mode 100755
index 000000000..4e3a50b60
--- /dev/null
+++ b/ci/run-windows-build.sh
@@ -0,0 +1,74 @@
+#!/usr/bin/env bash
+#
+# Script to trigger the a Git for Windows build and test run.
+# Set the $GFW_CI_TOKEN as environment variable.
+# Pass the branch (only branches on https://github.com/git/git are
+# supported) and a commit hash.
+#
so only git/git from github gets built on windows, not other peoples
trees. One cannot use travis to test ones changes on windows before
submitting them
Thanks for pointing it out didn't notice it. I have been confused by
the presence of the build named 'Windows' that I see even on my tree. I
always see a green check mark near it which tricked me into believing
that they were running successfully. I didn't know they were being
skipped all these days!
Yes I only noticed the other day that the windows job only ran for a
minute so I looked at the output log and saw it checks the repo and just
exits if it's not git/git
May be the Windows build exit with failure on other repos rather than
saying it passes?
I'm not quite sure what you're asking. If the tests aren't run it needs
to look like a pass or everyone's branches would be marked as failing on
github and more importantly it wouldn't be clear when there was a real
failure on linux/macos. If the tests are run then it will pass/fail
depending on the test result.
Best Wishes
Phillip
---
Kaartic
