On Sat, May 19, 2007 at 05:51:35PM -0700, Junio C Hamano wrote: > Frank Lichtenheld <frank@xxxxxxxxxxxxxx> writes: > > > On Mon, May 14, 2007 at 02:28:29PM -0700, Junio C Hamano wrote: > >> Frank Lichtenheld <frank@xxxxxxxxxxxxxx> writes: > >> > For the record, cvs (server side) does the following in this particular situation: > >> > buf_output0 (buf_to_net, "I HATE YOU\n"); > >> > buf_flush (buf_to_net, true); > >> > > >> > /* Don't worry about server_cleanup, server_active isn't set > >> > yet. */ > >> > exit (EXIT_FAILURE); > >> > >> Ok, I stand corrected. If there is a pattern to emulate, that > >> should be found in the real cvs server. > > > > Will you correct the patch then back to my version? master still has > > your version of it AFAICT. > > Will do, but then we would also have to vet all the error exit > paths to match what the real cvsserver does, wouldn't we? Sure. But it is nothing utterly important. It just so happens that I already have a test for this one case and would like to see it fixed before submitting the test patches again. > We've survived without that so far, so while I'll apply the > above change before 1.5.2, I think we do not have to have the > release wait for fixes to the other error exit paths. Agreed. Gruesse, -- Frank Lichtenheld <frank@xxxxxxxxxxxxxx> www: http://www.djpig.de/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
