On Thu, Aug 3, 2017 at 9:34 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Christian Couder <christian.couder@xxxxxxxxx> writes: > >> diff --git a/external-odb.h b/external-odb.h >> new file mode 100644 >> index 0000000000..9989490c9e >> --- /dev/null >> +++ b/external-odb.h >> @@ -0,0 +1,8 @@ >> +#ifndef EXTERNAL_ODB_H >> +#define EXTERNAL_ODB_H >> + >> +const char *external_odb_root(void); >> +int external_odb_has_object(const unsigned char *sha1); >> +int external_odb_get_object(const unsigned char *sha1); > > Even though ancient codebase of ours deliberately omitted them, I > think our recent trend is to explicitly spell "extern " in headers. > >> diff --git a/odb-helper.h b/odb-helper.h >> new file mode 100644 >> index 0000000000..5800661704 >> --- /dev/null >> +++ b/odb-helper.h > > Likewise. Ok, I am adding "extern " to the headers.
