René Scharfe <l.s.r@xxxxxx> writes: > Am 06.09.2017 um 21:51 schrieb Junio C Hamano: >> Rene Scharfe <l.s.r@xxxxxx> writes: >> >>> If format_tracking_info() returns 0 only if it didn't touch its strbuf >>> parameter, so it's OK to exit early in that case. Clean up sb in the >>> other case. >> >> These two "if"s confuse me; perhaps the first one is not needed? > > Yes, removing it looks like the best way to make that sentence clearer. > Another would be to replace "only if" with "then". Either makes it understandable. Thanks.