On 08/23/2017 02:36 PM, Nguyễn Thái Ngọc Duy wrote: > This is a better place that will benefit all submodule callers instead > of just resolve_gitlink_ref() This is a nice sentiment, but I have to wonder whether we should rather be requiring callers to use the "canonical" submodule name rather than covering up their sloppiness for them (perhaps multiple times?). I vaguely remember intentionally limiting the number of functions that do this canonicalization, and having in mind the goal that the number should become smaller over time, not larger. For example, there could be some kind of `canonicalize_submodule_name()` function that callers can use to clean up whatever submodule string they have in hand, then let them use the cleaned up value from then on. I don't really know much about the callers, though, so that is more of a lazy philosophical speculation than a concrete suggestion. Michael
