On Sat, Aug 26, 2017 at 6:38 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >> At this point in the code, len is *always* <= 20. > > This is the kind of log message that makes me unconfortable, as it > lacks "because", and the readers would need to find out themselves > by following the same codepath the patch author already followed. > [...] That's a valid complaint. I've adjusted the patch series to add the assertion and explain the reasoning better in the commit message. I've pushed the revised series to GitHub, but I'll wait a couple of days to see if there's more feedback before resubmitting. Thanks, Michael
