On Sat, Aug 26, 2017 at 10:28 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: [...] > plenty that could be cleaned up in the area: > > * Make macro `GIT_NIBBLE` safer by adding some parentheses > * Remove some dead code > * Fix some memory leaks > * Fix some obsolete and incorrect comments > * Reject "notes" that are not blobs > > I hope the result is also easier to understand. I looked through the series, and the patches look good to me, although I do agree with Junio's comments on #2. Thanks for a long-overdue cleanup in one of the hairier parts of the notes code. The end result reads a lot better IMHO. ...Johan
