On 08/25, Junio C Hamano wrote: > Brandon Williams <bmwill@xxxxxxxxxx> writes: > > > + /* If using a new version put that stuff here after a second null byte */ > > + strbuf_addch(&request, '\0'); > > + strbuf_addf(&request, "version=%d%c", 2, '\0'); > > + /* subsequent supported versions can also be added */ > > + strbuf_addf(&request, "version=%d%c", 3, '\0'); > > Isn't this last one meant only as a comment? Sorry since this was structured as an RFC I didn't go back through the code with a fine tooth comb to ensure I removed or commented out any debugging statements. Stefan also pointed out to me that I left in an if (0) statement somewhere haha. -- Brandon Williams