On Wed, Aug 23, 2017 at 2:54 PM, Brandon Casey <drafnel@xxxxxxxxx> wrote: > On Wed, Aug 23, 2017 at 2:20 PM, Brandon Casey <drafnel@xxxxxxxxx> wrote: >> On Wed, Aug 23, 2017 at 2:04 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> Brandon Casey <drafnel@xxxxxxxxx> writes: >>> >>>> So is there any reason why didn't do something like the following in >>>> the first place? >>> >>> My guess is that we didn't bother; if we cared, we would have used a >>> single instance of const char in a read-only segment, instead of >>> such a macro. >> >> I think you mean something like this: >> >> const char * const strbuf_slopbuf = ""; Hmm, apparently it is sufficient to mark our current strbuf_slopbuf array as const and initialize it with a static string to trigger its placement into the read-only section by gcc (and clang). const char strbuf_slopbuf[1] = ""; -Brandon
