Nicolas Morey-Chaisemartin <nicolas@xxxxxxxxxxxxxxxxxxxxxx> writes: > curl_append_msgs_to_imap always returned 0, whether curl failed or not. > Return a proper status so git imap-send will exit with an error code > if womething wrong happened. > > Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@xxxxxxxxxxxxxxxxxxxxxx> > --- > imap-send.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/imap-send.c b/imap-send.c > index b2d0b849b..09f29ea95 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -1490,7 +1490,7 @@ static int curl_append_msgs_to_imap(struct imap_server_conf *server, > curl_easy_cleanup(curl); > curl_global_cleanup(); > > - return 0; > + return res == CURLE_OK; > } > #endif Wait a bit. Did you mean "res != CURLE_OK"? If we got an OK, we want to return 0 as success, because the value we return from here is returned by cmd_main() as-is to main() and to the outside world, no?
