Re: [PATCH v4 10/16] refs: remove dead for_each_*_submodule()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v4 10/16] refs: remove dead for_each_*_submodule()
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Wed, 23 Aug 2017 12:45:36 -0700
Cc: "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx>, Michael Haggerty <mhagger@xxxxxxxxxxxx>
In-reply-to: <20170823123704.16518-11-pclouds@gmail.com>
References: <20170823123704.16518-1-pclouds@gmail.com> <20170823123704.16518-11-pclouds@gmail.com>

On Wed, Aug 23, 2017 at 5:36 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
> These are used in revision.c. After the last patch they are replaced
> with the refs_ version. Delete them.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>

The refactoring up to this patch looks good to me.

Thanks,
Stefan

References:
- [PATCH v4 00/16] Fix git-gc losing objects in multi worktree
  - From: Nguyễn Thái Ngọc Duy
- [PATCH v4 10/16] refs: remove dead for_each_*_submodule()
  - From: Nguyễn Thái Ngọc Duy

Prev by Date: Re: Cannot checkout after setting the eol attribute
Next by Date: Re: [GSoC][PATCH v2 2/4] submodule--helper: introduce for_each_submodule()
Previous by thread: [PATCH v4 10/16] refs: remove dead for_each_*_submodule()
Next by thread: Re: [PATCH v4 10/16] refs: remove dead for_each_*_submodule()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux