On Wed, Aug 23, 2017 at 5:36 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > --- > refs.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/refs.c b/refs.c > index dec899a57a..522c4ab74f 100644 > --- a/refs.c > +++ b/refs.c > @@ -1636,7 +1636,6 @@ struct ref_store *get_submodule_ref_store(const char *submodule) > { > struct strbuf submodule_sb = STRBUF_INIT; > struct ref_store *refs; Do we need to assign NULL here, to cover the early outs? > - int ret; > > if (!submodule || !*submodule) { > /* > @@ -1648,19 +1647,14 @@ struct ref_store *get_submodule_ref_store(const char *submodule) > > refs = lookup_ref_store_map(&submodule_ref_stores, submodule); Answering the question from above, no we do not need to assign NULL as we have an unconditional assignment here and any early outs are after this. Thanks, Stefan