+cc git gui maintainer
On Mon, Aug 21, 2017 at 4:53 AM, Łukasz Stelmach <l.stelmach@xxxxxxxxxxx> wrote:
> With encoding on the file descriptor set to "binary" Tcl (8.6 in my case)
> does double conversion which breaks e.g. author name in amended commits.
>
> For example "\305\201ukasz" (as written by git cat-file) becomes
> "\303\205\302\201ukasz".
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
> ---
> git-gui/lib/commit.tcl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
> index 83620b7cb..bcb6499a0 100644
> --- a/git-gui/lib/commit.tcl
> +++ b/git-gui/lib/commit.tcl
> @@ -26,7 +26,7 @@ You are currently in the middle of a merge that has not been fully completed. Y
> set parents [list]
> if {[catch {
> set fd [git_read cat-file commit $curHEAD]
> - fconfigure $fd -encoding binary -translation lf
> + fconfigure $fd -encoding utf-8 -translation lf
> # By default commits are assumed to be in utf-8
> set enc utf-8
> while {[gets $fd line] > 0} {
> --
> 2.11.0
>
