Joel Teichroeb <joel@xxxxxxxxxxxxx> writes: > On Sat, Aug 19, 2017 at 1:55 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> Are you documenting an existing breakage? Are you extending test >> coverage for some breakage we recently fixed without adding tests to >> ensure that the fix will stay unbroken? Are you planning to touch >> the implementation (perhaps to add yet another feature that uses >> some existing code) and adding new tests in advance to avoid breaking >> the existing code? Some other motivation? >> > > I was just too lazy to write a cover letter, and thought these would > make sense on their own. I'll make sure to include a cover letter next > time. > > I just ripped them out of my patch series on implementing stash as a > builtin[1]. Since I haven't had time, I figured I could at least get > the additional tests I wrote into the codebase. OK, so it is the third one among my random 4 choices ;-) They do look sensible; I did not want to make sure they are not duplicates myself (i.e. a new test that makes sense may not be an undesired addition if the only effect it has is to eat more cycles without improving test coverage). Will queue. Thanks. > The tests mainly expand coverage of git stash, covering a few critical > error cases that didn't have tests. > > [1] https://public-inbox.org/git/20170608005535.13080-1-joel@xxxxxxxxxxxxx/ >
