On Thu, Aug 17, 2017 at 12:05:56PM -0700, Stefan Beller wrote: > On Thu, Aug 17, 2017 at 3:34 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > > When using git-mv with a submodule it will detect that and update the > > paths for its configurations (.gitmodules, worktree and gitfile). This > > does not work for nested submodules where a user renames the root > > submodule. > > > > We discovered this fact when working on on-demand fetch for renamed > > submodules. Lets add a test to document. > > > > Signed-off-by: Heiko Voigt <hvoigt@xxxxxxxxxx> > > --- > > t/t7001-mv.sh | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh > > index e365d1f..39f8aed 100755 > > --- a/t/t7001-mv.sh > > +++ b/t/t7001-mv.sh > > @@ -491,4 +491,13 @@ test_expect_success 'moving a submodule in nested directories' ' > > test_cmp actual expect > > ' > > > > +test_expect_failure 'moving nested submodules' ' > > + git commit -am "cleanup commit" && > > + git submodule add ./. sub_nested && > > If possible, I would avoid adding the repo itself > as a submodule as it is unrealistic in the wild. > > While it may be ok for the test here, later down the road > other tests making use of it it may become an issue with > the URL of the submodule. I just copied the shortcut that they were adding themselfes as submodule in 'setup submodule'. The whole setup of submodules in this test is like this. This way we already had a nested submodule structure which I could just add. I agree that this is unrealistic so I can change that in the test I am adding. But from what I have seen, this shortcut is taken in quite some places when dealing with submodules. Cheers Heiko
