On 18 August 2017 at 18:30, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx> writes: > >> On Friday 18 August 2017 01:25 AM, Junio C Hamano wrote: >>> Martin Ågren <martin.agren@xxxxxxxxx> writes: >>> >>>> On 17 August 2017 at 04:54, Kaartic Sivaraam >>>> <kaarticsivaraam91196@xxxxxxxxx> wrote: >>>>> Helped-by: Martin Ågren <martin.agren@xxxxxxxxx>, Junio C Hamano <gitster@xxxxxxxxx> >>>>> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx> >>>> I didn't expect a "Helped-by", all I did was to give some random >>>> comments. :-) I'm not so sure about the comma-separation, that seems to >>>> be a first in the project. >>> I didn't either ;-) >>> >>> The line looks odd so I'll remove it while queuing. >>> >>> Thanks for noticing. >> I should have been better with my wordings :) How about converting that >> line into two 'Suggestions-by:' or 'Reviewed-by:' ? > > I personally do not think either is needed for those small things we > saw in the discussion. > > Unless Martin feels strongly about it, that is. No, no strong feelings. Thanks.
