On Thu, Aug 17, 2017 at 10:50:07AM -0700, Brandon Williams wrote: > On 08/17, Stefan Beller wrote: > > On Thu, Aug 17, 2017 at 4:00 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > > > To make extending this logic later easier. > > > > > > Signed-off-by: Heiko Voigt <hvoigt@xxxxxxxxxx> > > > --- > > > I am quite sure I replicated the same logic but a few more eyes would be > > > appreciated. > > > > A code cleanup is appreciated! > > > > I thought Brandon had a series in flight doing a very similar cleanup here, > > but in master..pu there is nothing to be found. > > Yeah there are 2 series in flight which will probably conflict here. > bw/grep-recurse-submodules and bw/submodule-config-cleanup Ok then I will wait until those are in and then see if I can base the cleanup on top. I think it is only necessary as a preparation for the fully fledged fetch configuration logic mess we will get into once we get to the full recursive submodule fetch implementation. Not necessarily needed for the moved submodules. > > > > The code looks good to me. Thanks. Cheers Heiko
