Jonathan Tan wrote: > Christian Couder <christian.couder@xxxxxxxxx> wrote: >> In handshake_capabilities() we use warning() when a capability >> is not supported, so the exit code of the function is 0 and no >> further error is shown. This is a problem because the warning >> message doesn't tell us which subprocess cmd failed. [...] >> Let's improve the warning() message, so that we can know which >> subprocess cmd failed. >> >> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > > This looks reasonable to me. > > I am still wondering if protocol errors should be fatal, Yes, please. Thanks, Jonathan
