On Sat, Aug 12, 2017 at 03:27:21PM +0200, Martin Ågren wrote: > On 12 August 2017 at 10:47, Martin Koegler <martin.koegler@xxxxxxxxx> wrote: > > From: Martin Koegler <martin.koegler@xxxxxxxxx> > > > > --- > > bisect.c | 2 +- > > blame.c | 2 +- > > builtin/fmt-merge-msg.c | 2 +- > > builtin/mktag.c | 2 +- > > dir.c | 4 ++-- > > dir.h | 2 +- > > 6 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/bisect.c b/bisect.c > > index 2549eaf..0580c82 100644 > > --- a/bisect.c > > +++ b/bisect.c > > @@ -131,7 +131,7 @@ static void show_list(const char *debug, int counted, int nr, > > struct commit *commit = p->item; > > unsigned flags = commit->object.flags; > > enum object_type type; > > - unsigned long size; > > + size_t size; > > char *buf = read_sha1_file(commit->object.sha1, &type, &size); > > const char *subject_start; > > int subject_len; > > Would this need to be done in a patch where read_sha1_file is converted? I missed this first, because it is debug code requiring a code change to be enabled. It probably should be merged in my second patch. On the other hand that patch is already considered too large. Regards, Martin