Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Fri, Jul 28, 2017 at 5:58 PM, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > I sent this last bit a tad too soon in a checkout of sha1collisiondetection.git: > > $ make PREFIX=/tmp/local install >/dev/null 2>&1 && find /tmp/local/ -type f > /tmp/local/include/sha1dc/sha1.h > /tmp/local/bin/sha1dcsum > /tmp/local/bin/sha1dcsum_partialcoll > /tmp/local/lib/libsha1detectcoll.a > /tmp/local/lib/libsha1detectcoll.so.1.0.0 > /tmp/local/lib/libsha1detectcoll.la > > So the upstream library expects you (and it's documented in their README) to do: > > #include <sha1dc/sha1.h> > > But your patch is just doing: > > #include <sha1.h> > > At best this seems like a trivial bug and at worst us encoding some > Suse-specific packaging convention in git, since other distros would > presumably want to package this in /usr/include/sha1dc/sha1.h as > upstream suggests. I.e. using the ambiguous sha1.h name is not > something upstream's doing by default, it's something you're doing in > your package. I do not think I saw any updates to this thread. Should I consider the topic ti/external-sha1dc now abandoned? As we have finished Git 2.14 cycle, in preparation for the next one, the 'next' branch will be rewound and rebuilt early next week. I do not mind tentatively ejecting some topics that needs fix-ups out of 'next' to give them a clean restart. If there will be a reroll that addresses the concerns raised during the discussion, please let me know. Thanks.
