On Wed, Aug 09, 2017 at 10:34:09AM -0700, Stefan Beller wrote: > On Wed, Aug 9, 2017 at 5:02 AM, Jeff King <peff@xxxxxxxx> wrote: > > Since v2.12.0, Git does not compile with versions of curl > > older than 7.19.4. That version of curl is about 8 years > > old. This means it may still be used in some distributions > > with long-running support periods. But the fact that we > > haven't received a single bug report about the compile-time > > breakage implies that nobody cares about building recent > > releases on such platforms. > > I would not state it as bland, see how > https://public-inbox.org/git/20170806233850.14711-1-avarab@xxxxxxxxx/ > came here to the mailing list. Heh, I almost added "Or they are happy patching Git themselves". This _does_ make patching Git harder for them, because now there are a lot more spots to patch. > > As discussed in the previous two commits, this cleans up the > > code and gives a more realistic signal to users about which > > versions of Git are actually tested (in particular, this > > moves us past the potential use-after-free issues with curl > > older than 7.17.0). > > This is a good reason for this patch, though, so maybe just elide > the "nobody cares" part? I think I'd rather elaborate than elide. One of the reasons to split this into multiple patches is that it's a ready-made patch for a distributor to apply (in reverse) if they really want to. -Peff
