On Wed, Aug 09, 2017 at 03:14:22PM +0200, Ævar Arnfjörð Bjarmason wrote: > This whole series looks good to me. As I commented on in the thread you > referenced in 0/4 I think this is the right trade-off, and people like > me who occasionally compile git on older systems can just easily package > a newer curl as well if we need it. > > My reading of the curl history/docs is that you should squash this into > this last patch. It's code that's now dead since we require > 7.19.4. > > CURLAUTH_DIGEST_IE was added in 7.19.3, and as a comment this squash > removes indicates CURLOPT_USE_SSL hasn't been needed since 7.16.4: > https://curl.haxx.se/libcurl/c/CURLOPT_USE_SSL.html Thanks. Do you mind formatting this as a patch on top instead of a squash? I think it's sufficiently subtle that it should be separate from the main cleanup, which is just dropping our own internal #ifdefs. I guess that would make reverting harder, though. -Peff
