On Tue, Aug 8, 2017 at 5:07 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Hi, > > Stefan Beller wrote: > >> Nowadays there are better tutorials out there such as "Git from bottom up" >> or others, easily found online. Additionally to that a tutorial in our >> test suite is not as easy to discover as e.g. online tutorials. >> >> This test/tutorial was discovered by the patch author in the effort to >> migrate our tests in preparation to switch the hashing function. >> Transforming this tutorial to be agnostic of the underlying hash function >> would hurt its readability, hence being even less useful as a tutorial. >> >> Instead delete this test as >> (a) the functionality is tested elsewhere as well and >> (b) reducing the test suite to its core improves performance, which >> aids developers in keeping their development velocity. >> >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> >> --- >> t/t1200-tutorial.sh | 268 ---------------------------------------------------- >> 1 file changed, 268 deletions(-) >> delete mode 100755 t/t1200-tutorial.sh > > Interesting. When I first saw the diffstat I assumed you were talking > about a test that validates the examples in some manpage are correct. > But this is not that. > > There indeed appear to be other good tests for these commands, even > "git whatchanged", so for what it's worth, > > Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > > Thanks. 2ae6c70674 (Adapt tutorial to cygwin and add test case, 2005-10-13) seemed to imply that it was testing some part for Documentation/tutorial.txt though.
