Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > So the upstream library expects you (and it's documented in their README) to do: > > #include <sha1dc/sha1.h> > > But your patch is just doing: > > #include <sha1.h> > > At best this seems like a trivial bug and at worst us encoding some > Suse-specific packaging convention in git, since other distros would > presumably want to package this in /usr/include/sha1dc/sha1.h as > upstream suggests. I.e. using the ambiguous sha1.h name is not > something upstream's doing by default, it's something you're doing in > your package. It seems there still needs a bit more work on this patch. Thanks for reviewing and pointing out what needs to be addressed.
