From: "Junio C Hamano" <gitster@xxxxxxxxx>
Sent: Thursday, July 27, 2017 6:05 PM
John Szakmeister <john@xxxxxxxxxxxxxxx> writes:
On Mon, Jul 24, 2017 at 3:23 PM, Junio C Hamano <gitster@xxxxxxxxx>
wrote:
[snip]
I am reasonably sure that the command started its life as a pure
debugging aid.
The treatment of the negation _might_ impose conflicting goals to
its purpose as a debugging aid---a user who debugs his .gitignore
file would want to know what causes a thing that wants to be ignored
is not or vice versa, and use of the exit status to indicate if it
is ignored may not mesh well with its goal as a debugging aid, but I
didn't think about the potential issues deeply myself while writing
this response. As you mentioned, use of (or not using) "-v" could
be used as a sign to see which behaviour the end-user expects, I
guess.
Is there another way of checking to see if a file is ignored? If so,...
Maybe I sounded like waffling, but I do think "check-ignore" when
used as an end-user tool should be that command, to get a preview of
what would happen if you gave the path to "git add".
I was merely giving a possible explanation why it may not behave
like so in the current code, i.e. those who used it for debugging
their .gitignore files may have felt that the current way to handle
negation were more convenient during their debugging session.
But I think there is a way out to satisfy both groups of people.
What if we (re)define that "-v" is a way to ask "which entry, if
any, decides the final fate of this path?" question, and that is a
sign that the user is using it to debug their .gitignore? And we
use the exit status to mean "Yeah, there is an explicit entry that
decides the fate of the path" in that case, which is what the
current behaviour seems to be---the command exits with non-zero
status only when there is nothing that matches in the exclude
mechanism (which makes the final fate of the path to be 'not
ignored').
And we interpret the lack of "-v" as a signal that the user wants to
learn the fate of a given path via the exit status of the command,
which will "fix" the exit code to match the expectation in your
initial message in this thread.
Would that work well?
The old answer on StackOverflow
https://stackoverflow.com/questions/12144633/which-gitignore-rule-is-ignoring-my-file
has some of the older gory detail.
I also see that one of the changes was reverted (Revert "Merge branch
'nd/exclusion-regression-fix', 5cee3493, 18 Mar 2016
https://github.com/git/git/commit/5cee349370bd2dce48d0d653ab4ce99bb79a3415#diff-b9ad88b4882e66b5be4541046b713b51).
It doesn't look like any follow up happened to the check-ignore docs.
To me, the return status for the plain vanilla case should always work
correctly. So that is, given one path, using the current index, we know if
it is, or is not, ignored.
The verbose output for debugging should be able to be varied at will (e.g.
re-inclusion can show all operative lines in the debug output). It shouldn't
be a backward compatibility issue.
Maybe that, verbosely, for each path given, the summary status is also given
now that re-inclusion should be possible, which would not have been required
before.
--
Philip
