2017-07-22 19:28 GMT+08:00 Johannes Schindelin <Johannes.Schindelin@xxxxxx>: > Hi, > > On Sat, 22 Jul 2017, Jiang Xin wrote: > >> 2017-07-22 7:34 GMT+08:00 Junio C Hamano <gitster@xxxxxxxxx>: >> > Jiang Xin <worldhello.net@xxxxxxxxx> writes: >> > >> >> A very small hack on gettext. > > I am 100% opposed to this hack. It's really very small, see: * https://github.com/jiangxin/gettext/commit/b0a72643 * https://public-inbox.org/git/a87e7252bf9de8a87e5dc7712946f72459778d6c.1500684532.git.worldhello.net@xxxxxxxxx/ > It is already cumbersome enough to find > out what is involved in i18n (it took *me* five minutes to find out that > much of the information is in po/README, with a lot of information stored > *on an external site*, and I still managed to miss the `make pot` target). > > If at all, we need to make things easier instead of harder. If it is only the l10n coordinate's duty to generate po/git.pot, the tweak is OK. But if other guys need to recreate po/git.pot, it's hard, especially for guys working on Mac or Windows. > > Requiring potential volunteers to waste their time to compile an > unnecessary fork of gettext? Not so great an idea. > > Plus, each and every Git build would now have to compile their own > gettext, too, as the vanilla one would not handle the .po files containing > %<PRItime>!!! No, only l10n coordinator and potential po/git.pot generator are involved. > > So let's go with Junio's patch. I agree. We just go with the sed-then-cleanup version until we meet ambiguities (I mean some words other than PRItime need to be replaced). -- Jiang Xin
