Hi Stefan, On Fri, 14 Jul 2017, Stefan Beller wrote: > On Fri, Jul 14, 2017 at 7:44 AM, Johannes Schindelin > <johannes.schindelin@xxxxxx> wrote: > > > -static int subject2item_cmp(const struct subject2item_entry *a, > > - const struct subject2item_entry *b, const void *key) > > +static int subject2item_cmp(const void *fndata, > > This could also be named unused_fndata. Sure. I simply took the version Junio used when he merged the previous patch series iteration into `pu`. The function is short enough, though, that I feel it obvious that the parameter is unused. Ciao, Dscho