On Thu, Jul 13, 2017 at 7:55 AM, Jeff King <peff@xxxxxxxx> wrote: > This is a cleanup of the patch I posted last October: > > https://public-inbox.org/git/20161010151517.6wszhuyp57yfncaj@xxxxxxxxxxxxxxxxxxxxx/ > > The general idea is that it's rather confusing that "%C(red)" in a > pretty-print format does not currently respect color.ui, --no-color, or > the usual isatty check on stdout. This series changes that. Note that > this is a backwards-incompatible change, but the general sentiment in > that earlier thread seemed to be that the existing behavior is arguably > buggy. See patch 14 for more discussion. > > The patch stalled back then because I wanted to make sure that > ref-filter's color placeholders behaved the same. That required some > refactoring which conflicted badly with kn/ref-filter-branch-list. Now > that it has graduated, I was able to rebase on top. > > This version also takes into account feedback from the original thread. > And as I added tests, it surfaced a few corner cases around color config > that I've dealt with here. The last two patches are the most > interesting bits. > I have reviewed these slightly and think this series is a good change. Thanks, Stefan
