On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > + if (repo_submodule_init(&submodule, superproject, path)) > + return 0; What happens if we go through the "return 0", do we rather want to print an error ? > + /* add objects to alternates */ > + add_to_alternates_memory(submodule.objectdir); Not trying to make my object series more important than it is... but we really don't want to spread this add_to_alternates_memory hack. :/ I agree with Jacob that a patch with such a diffstat is a joy to review. :) Thanks, Stefan
