On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > In a subsequent patch, sha1_file will need to append object names in the > form of "unsigned char *" to oid arrays. Teach sha1-array support for > that. > > Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> This breaks the oid/sha1 barrier? I would have expected the caller to do a oid_array_append_oid(&array, sha1_to_oid(sha1)); with sha1_to_oid working off some static memory, such that the call to oid_array_append_oid (which we have as oid_array_append) is just as cheap? Could you say more in the commit message on why we collude sha1 and oids here? Thanks, Stefan
