On Tue, Jul 11, 2017 at 12:13:59PM -0700, Stefan Beller wrote: > > There are other die calls hidden deeper. For instance: > > > > $ git -c core.ignorecase=foo help config > > fatal: bad numeric config value 'foo' for 'core.ignorecase': invalid unit > > > > Those ones are hard to fix without changing the call signature of > > git_config_bool(). > > Good point. While looking at it, parse_help_format can also die, > so building a safe git help config is hard: > > git config --global help.format foo > # everything is broken, how do I fix it? > git help config # breaks, too, for the same reason as you outlined :/ Yeah, I think that should be switched to return an error, and probably all errors from git_help_config() should issue a warning and still return 0. -Peff
