Jeff King <peff@xxxxxxxx> writes: > ... And you could even drop origlen by > replacing it with "baselen - 3" at the end. But somehow doing the > computation on the fly actually seems more complicated to me (from the > perspective of a reader who is trying to make sure all is correct). True enough. I personally do not mind any of the three variants (including the original) and would rather not spend too much time micro-optimizing this codepath, lest the next clever person starts to turn the loop in for_each_loose_file_in_objdir() to a nested loop that runs 16 times each to avoid copying the same leading byte again and again ;-)
