On Fri, Jul 7, 2017 at 8:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ben Peart <peartben@xxxxxxxxx> writes: > >> On 6/14/2017 2:36 PM, Junio C Hamano wrote: >>> Ben Peart <peartben@xxxxxxxxx> writes: >>> >>>>> Having said all that, I think you are using this ONLY on windows; >>>>> perhaps it is better to drop #ifdef GIT_WINDOWS_NATIVE from all of >>>>> the above and arrange Makefile to build test-drop-cache only on that >>>>> platform, or something? >>>> >>>> I didn't find any other examples of Windows only tools. I'll update >>>> the #ifdef to properly dump the file system cache on Linux as well and >>>> only error out on other platforms. >>> >>> If this will become Windows-only, then I have no problem with >>> platform specfic typedef ;-) I have no problem with CamelCase, >>> either, as that follows the local convention on the platform >>> (similar to those in compat/* that are only for Windows). >>> >>> Having said all that. >>> >>> Another approach is to build this helper on all platforms, ... > > ... and having said all that, I think it is perfectly fine to do > such a clean-up long after the series gets more exposure to wider > audiences as a follow-up patch. Let's get the primary part that > affects people's everyday use of Git right and then worry about the > test details later. > > A quick show of hands to the list audiences. How many of you guys > actually tried this series on 'pu' and checked to see its > performance (and correctness ;-) characteristics? As you can guess from my previous replies to this thread (and the previous version of this patch series), I lightly tried it and checked its performance for Booking.com. > Do you folks like it? Rather not have such complexity in the core > part of the system? A good first step to start adding more > performance improvements? No opinion? I already gave my opinion which I think is shared with Ævar. In short I don't think it should be a hook, as that limits the performance and is not necessary, but it is going in the right direction.
