On 2007-05-15 16:41:47 +0100, Catalin Marinas wrote: > On 05/05/07, Yann Dirson <ydirson@xxxxxxxxxx> wrote: > > > This patch uses -M when generating diffs, which then looks fine, > > just like any other git-generated diff. > > I think we should only use -M for "files", "status", "show", "diff" > but not for "export" and "mail", maybe by adding an extra parameter > to git.diff() (or we could have this configurable or with an cmd > line option). The reason is that I send patches that might not be > applied with GIT. Seems like a good idea to me: default to -M whenever the consumer is guaranteed to understand it, and have it as an option defaulting to off when we export data. -- Karl Hasselström, kha@xxxxxxxxxxx www.treskal.com/kalle - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html