On 05/07/17 18:35, Kaartic Sivaraam wrote: > The sample hook to prepare the commit message before > a commit allows users to opt-in to add the signature > to the commit message. The signature is added at a place > that isn't consistent with the "-s" option of "git commit". > Further, it could go out of view in certain cases. > > Add the signature in a way similar to "-s" option of > "git commit" using git's interpret-trailers command. > > It works well in all cases except when the user invokes > "git commit" without any arguments. In that case manually > add a new line after the first line to ensure it's consistent > with the output of "-s" option. > > While at it, name the input parameters to improve readability > of script. I assume each occurrence of 'signature' in the commit message, including the subject, should be 'sign-off' (or Signed-off-by) instead. Yes? (when I hear 'signature', I think GPG signature). ATB, Ramsay Jones
