Kaartic Sivaraam <kaarticsivaraam91196@xxxxxxxxx> writes:
> +sed -e '/^# Please enter the .*/ {
> + N
> + N
> + d
> +}' "$1" >'.sed-output.temp' && mv '.sed-output.temp' "$1"
Three things that caught my eyes:
- Between "git commit --cleanup=strip" and "git commit --cleanup=verbatim",
lines that make up this initial instruction section are different.
- "git grep 'Please enter the '" finds that this string is subject
to translation, so the pattern may not match (in which case it
will be a no-op without doing any harm, which is OK).
- core.commentChar can be set to something other than '#', so the
pattern may not match (I do not offhand know if that may cause a
wrong line to match, causing harm, or not).
As merely an example, it probably is OK to say "this won't work if
you are not using the C locale, and/or you are using custom
core.commentChar". So if we disregard the latter two, I would think
sed -e '/^# Please enter the commit message /,/^#$/d'
may be simpler to reason about to achieve the same goal.
Thanks.
